-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Move clusterctl to book #1397
📖 Move clusterctl to book #1397
Conversation
Welcome @kikisdeliveryservice! |
Hi @kikisdeliveryservice. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d7b6954
to
5906be9
Compare
hmm in the original: https://github.com/kubernetes-sigs/cluster-api/blob/master/docs/how-to-use-clusterctl.md#what-is-clusterctl the link in provider implementations just goes to the repo itself? Ok fixed in my version. :) |
5906be9
to
c2b4a9a
Compare
84706c7
to
1976a0a
Compare
@vincepri 2 questions (since I'm new here): For this PR should I delete the existing how-to-user-clusterctl.md doc as well? Should i update: cluster-api/hack/verify-doctoc.sh Line 26 in 1f6bf65
|
@kikisdeliveryservice It should be ok to remove the file and the reference as well, we should remove the TOC from the file given that the book doesn't require it |
/ok-to-test |
1976a0a
to
fcd9686
Compare
Thanks! Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/assign @detiber
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @detiber I'll get those suggestions in later today. 😺 |
fcd9686
to
d2b4d7e
Compare
d2b4d7e
to
5361aed
Compare
- moved docs/how-to-use-clusterctl.md to docs/book/src/tooling/clusterctl.md - deleted docs/book/src/tooling/clusterctl.md - remove ref to clusterctl.md from /hack/verify-doctoc.sh - small updates to doc for version for v1alpha2 - add depreciation notice
5361aed
to
b98fc15
Compare
/lgtm |
Move clusterctl to book
- moved docs/how-to-use-clusterctl.md to docs/book/src/tooling/clusterctl.md
- deleted docs/book/src/tooling/clusterctl.md
- remove ref to clusterctl.md from /hack/verify-doctoc.sh
Fixes: #1372