⚠️ Add OwnerReference to Kubeconfig secret #1403
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
controllers/cluster_controller.go
Outdated
| @@ -216,6 +217,20 @@ func (r *ClusterReconciler) reconcileDelete(ctx context.Context, cluster *cluste | |||
| } | |||
| } | |||
|
|
|||
| // Delete the Cluster's Kubeconfig Secret, if any. | |||
There was a problem hiding this comment.
If there is an OwnerReference, this shouldn't be needed.
There was a problem hiding this comment.
We don't set one today, should we?
There was a problem hiding this comment.
We should be adding the OwnerRef when we create, and if someone is providing a pre-existing kubeconfig secret, then we should likely not assume that we can delete it for them.
There was a problem hiding this comment.
Changed it up to add the owner ref
Signed-off-by: Vince Prignano <vincepri@vmware.com>
vincepri
force-pushed
the
remove-secret-delete
branch
from
01c36ec
to
8723cca
Compare
vincepri
changed the title
k8s-ci-robot
removed
the
size/S
vincepri
changed the title
k8s-ci-robot
added
the
size/XS
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Should we add a unit test? |
|
@ncdc I might need to follow-up with a clusterctl fix as well to remove the OwnerRef if it's a cluster one, I'll look into it later today |
Signed-off-by: Vince Prignano vincepri@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #