-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃 Adds chuckha to maintainers list #1409
Conversation
Signed-off-by: Chuck Ha <chuckh@vmware.com>
/hold cancel This has been around for at least a week! |
/lgtm |
(Waiting to give a heads up to tomorrow's meeting) Side note: should we do this as part of a the promotion process we discussed last week? |
Do you all want to merge this as-is, and then do a PR for promotions, or do a single PR for all promotions? (I'm fine either way.) |
I'll leave it up to @chuckha. I'd prefer to do promotions/removals in one batch if possible like we did in the early days of cluster api. We're also going to bring in other repositories with new reviewers/maintainers, which should be taken into account as well |
Those owner files are separate and will likely each have their own pr anyway. Let's merge and we can do an overall project OWNERS files update later |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha, ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Chuck Ha chuckh@vmware.com
What this PR does / why we need it:
Adds @chuckha to the maintainers list
lazy consensus! Probably keep this open for a week
/hold