Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃 Adds chuckha to maintainers list #1409

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

chuckha
Copy link
Contributor

@chuckha chuckha commented Sep 9, 2019

Signed-off-by: Chuck Ha chuckh@vmware.com

What this PR does / why we need it:
Adds @chuckha to the maintainers list

lazy consensus! Probably keep this open for a week

/hold

Signed-off-by: Chuck Ha <chuckh@vmware.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 9, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 9, 2019
@chuckha
Copy link
Contributor Author

chuckha commented Sep 24, 2019

/hold cancel

This has been around for at least a week!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2019
@detiber
Copy link
Member

detiber commented Sep 24, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2019
@vincepri
Copy link
Member

(Waiting to give a heads up to tomorrow's meeting)

Side note: should we do this as part of a the promotion process we discussed last week?

@ncdc
Copy link
Contributor

ncdc commented Sep 26, 2019

Do you all want to merge this as-is, and then do a PR for promotions, or do a single PR for all promotions? (I'm fine either way.)

@vincepri
Copy link
Member

I'll leave it up to @chuckha. I'd prefer to do promotions/removals in one batch if possible like we did in the early days of cluster api.

We're also going to bring in other repositories with new reviewers/maintainers, which should be taken into account as well

@chuckha
Copy link
Contributor Author

chuckha commented Sep 26, 2019

Those owner files are separate and will likely each have their own pr anyway. Let's merge and we can do an overall project OWNERS files update later

@ncdc
Copy link
Contributor

ncdc commented Sep 26, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha, ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 122e605 into kubernetes-sigs:master Sep 26, 2019
@chuckha chuckha deleted the maintainers branch September 26, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants