-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃 Make getMachinesInCluster a helper function #1417
🏃 Make getMachinesInCluster a helper function #1417
Conversation
ff53dd5
to
6129c87
Compare
controllers/machine_helpers.go
Outdated
|
||
// getMachinesInCluster returns all of the Machine objects | ||
// that belong to the cluster with given namespace/name | ||
func getMachinesInCluster(ctx context.Context, c client.Client, namespace, name string) ([]*clusterv1.Machine, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see a test case for this function and perhaps a rename to getActiveMachinesInCluster
. It could be read as "get all machines in a cluster" but the function is getting the non-deleted (is active the right word?) machines.
Regardless of a rename, this functionality should be reflected in the godoc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to rename
6129c87
to
03abc64
Compare
nice! /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber, tahsinrahman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1414