Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Updated release docs #1424

Merged
merged 1 commit into from
Sep 20, 2019

Conversation

alejandrox1
Copy link
Contributor

What this PR does / why we need it:
Update a reference to the GCR used to the cluster-api-controller image

Signed-off-by: alejandrox1 alarcj137@gmail.com

Update reference to gcr registry

Signed-off-by: alejandrox1 <alarcj137@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 17, 2019
@alejandrox1 alejandrox1 changed the title Updated release docs 📖 Updated release docs Sep 17, 2019
@alejandrox1
Copy link
Contributor Author

From the context in the release docs it seems like it is the right thing todo but im not completely sure if this is correct.

@alejandrox1
Copy link
Contributor Author

/assign @detiber

@detiber
Copy link
Member

detiber commented Sep 20, 2019

@alejandrox1 thanks for catching this.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alejandrox1, detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2b0b75e into kubernetes-sigs:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants