-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add CABPK abbreviation and v1alpha2-ize other abbreviations #1432
📖 Add CABPK abbreviation and v1alpha2-ize other abbreviations #1432
Conversation
Hi @erwinvaneyk. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/assign @ncdc
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erwinvaneyk, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
CAPO | Cluster API Provider OpenStack | ||
CAPV | Cluster API Provider vSphere | ||
CAPZ | Cluster API Provider Azure | ||
CAPA | Cluster API AWS infrastructure provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CAPA | Cluster API AWS infrastructure provider | |
CAPA | Cluster API infrastructure Provider AWS |
CAPV | Cluster API Provider vSphere | ||
CAPZ | Cluster API Provider Azure | ||
CAPA | Cluster API AWS infrastructure provider | ||
CAPD | Cluster API Docker infrastructure provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CAPD | Cluster API Docker infrastructure provider | |
CAPD | Cluster API infrastructure Provider Docker |
CAPZ | Cluster API Provider Azure | ||
CAPA | Cluster API AWS infrastructure provider | ||
CAPD | Cluster API Docker infrastructure provider | ||
CAPO | Cluster API OpenStack infrastructure provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CAPO | Cluster API OpenStack infrastructure provider | |
CAPO | Cluster API infrastructure Provider OpenStack |
CAPA | Cluster API AWS infrastructure provider | ||
CAPD | Cluster API Docker infrastructure provider | ||
CAPO | Cluster API OpenStack infrastructure provider | ||
CAPV | Cluster API vSphere infrastructure provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CAPV | Cluster API vSphere infrastructure provider | |
CAPV | Cluster API infrastructure Provider vSphere |
CAPD | Cluster API Docker infrastructure provider | ||
CAPO | Cluster API OpenStack infrastructure provider | ||
CAPV | Cluster API vSphere infrastructure provider | ||
CAPZ | Cluster API Azure infrastructure provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CAPZ | Cluster API Azure infrastructure provider | |
CAPZ | Cluster API infrastructure Provider Azure |
CAPO | Cluster API OpenStack infrastructure provider | ||
CAPV | Cluster API vSphere infrastructure provider | ||
CAPZ | Cluster API Azure infrastructure provider | ||
CABPK | Cluster API Kubeadm bootstrap provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CABPK | Cluster API Kubeadm bootstrap provider | |
CABPK | Cluster API Bootstrap Provider Kubeadm |
doh, review in too late :( |
follow-up 😛 |
@detiber it's the effort that counts! 😁 |
This PR adds CABPK (kubeadm bootstrap provider) to the abbreviation overview. It further rewords the abbreviations in the book to emphasize the difference between the infrastructure and bootstrap providers introduced in v1alpha2