-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Clarify Machine.Spec.ObjectMeta use in godoc #1454
⚠️ Clarify Machine.Spec.ObjectMeta use in godoc #1454
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/hold |
80c73c2
to
ead62ec
Compare
/hold cancel ptal |
90d3465
to
bd62092
Compare
api/v1alpha2/machine_types.go
Outdated
@@ -37,9 +37,11 @@ const ( | |||
|
|||
// MachineSpec defines the desired state of Machine | |||
type MachineSpec struct { | |||
// ObjectMeta will autopopulate the Node created. Use this to | |||
// DEPRECATED: ObjectMeta will autopopulate the Node created. Use this to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not leave the text in here about autopopulating stuff. It's incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ptal
Signed-off-by: Vince Prignano <vincepri@vmware.com>
bd62092
to
872349b
Compare
/lgtm |
Signed-off-by: Vince Prignano vincepri@vmware.com
What this PR does / why we need it:
Not a breaking change, but wanted to make it clear for users that this didn't do what it said it did.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #