Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Do not re-queue forever if only cluster is deployed #1466

Merged
merged 2 commits into from
Oct 3, 2019
Merged

🐛 Do not re-queue forever if only cluster is deployed #1466

merged 2 commits into from
Oct 3, 2019

Conversation

tahsinrahman
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1460

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2019
@vincepri
Copy link
Member

vincepri commented Sep 27, 2019 •
edited

Is this the actual behavior we want though? A Cluster object without any Machines won't become a Kubernetes Cluster

vincepri
vincepri reviewed Sep 30, 2019
View reviewed changes
controllers/cluster_controller_phases.go Outdated Show resolved Hide resolved
controllers/cluster_controller_phases.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 30, 2019
@tahsinrahman tahsinrahman reopened this Sep 30, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 30, 2019
chuckha
chuckha reviewed Oct 1, 2019
View reviewed changes
Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like what I was expecting -- Would it be possible to add a test for this new behavior?

@tahsinrahman
Copy link
Contributor Author

tahsinrahman commented Oct 2, 2019 •
edited

This looks like what I was expecting -- Would it be possible to add a test for this new behavior?

@chuckha I'm not sure how to test the behavior. Should i write a unit test for reconcileKubeconfig that will check if ca secret is not found, its a requeueAfterError?

edit: added, ptal 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 2, 2019
vincepri
vincepri approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/assign @chuckha

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tahsinrahman, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2019
@chuckha
Copy link
Contributor

chuckha commented Oct 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6a0574c into kubernetes-sigs:master Oct 3, 2019
@tahsinrahman tahsinrahman deleted the requeue-only-cluster branch October 13, 2019 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@detiber detiber detiber left review comments

@vincepri vincepri vincepri approved these changes

@justinsb justinsb Awaiting requested review from justinsb

@chuckha chuckha Awaiting requested review from chuckha

Assignees

@chuckha chuckha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better handle the error case when kubeconfig does not exist
5 participants
@tahsinrahman @vincepri @k8s-ci-robot @chuckha @detiber