-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Do not re-queue forever if only cluster is deployed #1466
🐛 Do not re-queue forever if only cluster is deployed #1466
Conversation
Is this the actual behavior we want though? A Cluster object without any Machines won't become a Kubernetes Cluster |
d912ee6
to
1bfff7c
Compare
1bfff7c
to
bf790fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like what I was expecting -- Would it be possible to add a test for this new behavior?
227fee0
to
fa022be
Compare
@chuckha I'm not sure how to test the behavior. Should i write a unit test for edit: added, ptal 😃 |
3d4c20e
to
3882576
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/assign @chuckha
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tahsinrahman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1460