⚠️ Build master tag on master instead of latest
#1513
Conversation
Signed-off-by: Vince Prignano <vincepri@vmware.com>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Are there any docs that should be updated to reflect this change? |
|
The quick start uses published components, I'll sweep through the repositories |
| @@ -246,7 +246,7 @@ release-binary: $(RELEASE_DIR) | |||
| release-staging: ## Builds and push container images to the staging bucket. | |||
| REGISTRY=$(STAGING_REGISTRY) $(MAKE) docker-build-all docker-push-all release-alias-tag | |||
|
|
|||
| RELEASE_ALIAS_TAG=$(shell if [ "$(PULL_BASE_REF)" = "master" ]; then echo "latest"; else echo "$(PULL_BASE_REF)"; fi) | |||
| RELEASE_ALIAS_TAG=$(PULL_BASE_REF) | |||
There was a problem hiding this comment.
You can probably get rid of this and use PULL_BASE_REF below on line 253?
There was a problem hiding this comment.
I wanted to keep it if we want to do the stable, or have fancy tags at some point like we were discussing in the issue
|
/cc @akutz |
|
Is there any concern over the name of the tag? We can't help the name of the branch, but could this be the |
|
Good point. |
Signed-off-by: Vince Prignano vincepri@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Related to #1510