-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixes an issue when using an empty namespace with clusterctl create
#1590
🐛 Fixes an issue when using an empty namespace with clusterctl create
#1590
Conversation
Welcome @aaroniscode! |
Hi @aaroniscode. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I wasn't sure what branch to use as the base for the PR. With |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aaroniscode, ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v0.3.0 Feel free to retitle again if this doesn't capture the change |
clusterctl create
/lgtm |
What this PR does / why we need it:
clusterctl
fails to create a cluster if the Cluster API resources don't have a namespace defined.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1536