Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 fix the quickstart AWS iamInstanceProfile #1676

Merged
merged 1 commit into from
Oct 29, 2019
Merged

📖 fix the quickstart AWS iamInstanceProfile #1676

merged 1 commit into from
Oct 29, 2019

Conversation

randomvariable
Copy link
Member

Cherry pick of #1641 on release-0.2.

#1641: fix the quickstart AWS iamInstanceProfile

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2019
@vincepri vincepri changed the title Automated cherry pick of #1641: fix the quickstart AWS iamInstanceProfile 📖 Fix the quickstart AWS iamInstanceProfile Oct 29, 2019
@randomvariable randomvariable changed the title 📖 Fix the quickstart AWS iamInstanceProfile 📖 fix the quickstart AWS iamInstanceProfile Oct 29, 2019
vincepri
vincepri approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/milestone v0.2.0
/approve

@k8s-ci-robot
Copy link
Contributor

@vincepri: The provided milestone is not valid for this repository. Milestones in this repository: [Next, v0.2.x, v0.3.0]

Use /milestone clear to clear the milestone.

In response to this:

/milestone v0.2.0
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2019
@vincepri
Copy link
Member

/milestone v0.2.x

@k8s-ci-robot k8s-ci-robot added this to the v0.2.x milestone Oct 29, 2019
@detiber
Copy link
Member

detiber commented Oct 29, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit 711dabe into kubernetes-sigs:release-0.2 Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@detiber detiber Awaiting requested review from detiber

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@detiber detiber

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.2.x
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@randomvariable @k8s-ci-robot @vincepri @detiber @aaroniscode