-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clusterctl/kind: return stdout and not combined output #1792
clusterctl/kind: return stdout and not combined output #1792
Conversation
1f60998
to
910389a
Compare
910389a
to
c231b33
Compare
yet, |
@neolit123 Are you using Go 1.12 or 1.13? |
@vincepri go 1.13.4 |
We’re still on Go 1.12, the linter is failing because go.mod generates different results when using a version vs the other, if you can switch and regenerate the CI should go green |
Ideally only the stdout of kind commands should be captured and returned, in case kind commands also contain stderr. Fixes a recent bug where the kind command "get kubeconfig-path" started printing a deprecation message on stderr.
c231b33
to
8618237
Compare
@vincepri updated. this force-push made a change to gomod but it's not reflected here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Ideally only the stdout of kind commands should be captured
and returned, in case kind commands also contain stderr.
Fixes a recent bug where the kind command "get kubeconfig-path"
started printing a deprecation message to stderr.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):NONE?
/kind bug
/priority important-longterm