-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Use KubeadmControlPlane in the e2e test #2015
Conversation
Signed-off-by: Chuck Ha <chuckh@vmware.com>
/cc @akutz |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @wfernandes |
Hi @chuckha, Want me to run CAPV with this PR and see what happens? |
@akutz Ah, I should have stated why I tagged you. I mostly wanted you to see where this test was going and to make sure that CAPV was going to be using the kubeadm control plane controller -- but I think I'll make this its own test and keep the existing control-plane set up test that you're already using. That way providers can choose to use this test or not. |
thanks to @akutz, should remove the logs and such. |
Signed-off-by: Chuck Ha chuckh@vmware.com
/hold
I'm holding because this test requires Delete to be implemented before it can pass, but this is the direction the e2e framework is headed.
As KubeadmControlPlane is not strictly a required piece, I'm considering adding this as an additional test that folks don't have to use as they may not use the KubeadmControlPlane with their set up.