Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Use KubeadmControlPlane in the e2e test #2015

Closed
wants to merge 1 commit into from

Conversation

chuckha
Copy link
Contributor

@chuckha chuckha commented Jan 7, 2020

Signed-off-by: Chuck Ha chuckh@vmware.com

/hold

I'm holding because this test requires Delete to be implemented before it can pass, but this is the direction the e2e framework is headed.

As KubeadmControlPlane is not strictly a required piece, I'm considering adding this as an additional test that folks don't have to use as they may not use the KubeadmControlPlane with their set up.

Signed-off-by: Chuck Ha <chuckh@vmware.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 7, 2020
@chuckha
Copy link
Contributor Author

chuckha commented Jan 7, 2020

/cc @akutz

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2020
@chuckha
Copy link
Contributor Author

chuckha commented Jan 7, 2020

/cc @wfernandes

@akutz
Copy link
Contributor

akutz commented Jan 7, 2020

Hi @chuckha,

Want me to run CAPV with this PR and see what happens?

@chuckha
Copy link
Contributor Author

chuckha commented Jan 8, 2020

@akutz Ah, I should have stated why I tagged you. I mostly wanted you to see where this test was going and to make sure that CAPV was going to be using the kubeadm control plane controller -- but I think I'll make this its own test and keep the existing control-plane set up test that you're already using. That way providers can choose to use this test or not.

@chuckha chuckha mentioned this pull request Jan 8, 2020
33 tasks
@chuckha
Copy link
Contributor Author

chuckha commented Jan 8, 2020

thanks to @akutz, should remove the logs and such.

@chuckha chuckha closed this Jan 8, 2020
@chuckha chuckha deleted the kcp-e2e branch January 8, 2020 21:25
@chuckha chuckha restored the kcp-e2e branch January 8, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants