✨ Delete the ControlPlaneRef object if it exists #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
chuckha
commented
Jan 17, 2020
vincepri
reviewed
Jan 17, 2020
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
chuckha
force-pushed
the
delete-control-plane
branch
from
250d8a2
to
98981b2
Compare
k8s-ci-robot
added
size/S
ncdc
added
the
area/control-plane
ncdc
reviewed
Jan 17, 2020
ncdc
reviewed
Jan 17, 2020
chuckha
force-pushed
the
delete-control-plane
branch
from
98981b2
to
ab6de81
Compare
|
@ncdc ok! now go for the review :) |
ncdc
reviewed
Jan 17, 2020
Signed-off-by: Chuck Ha <chuckh@vmware.com>
chuckha
force-pushed
the
delete-control-plane
branch
from
ab6de81
to
9d59b43
Compare
chuckha
commented
Jan 17, 2020
|
LGTM. @vincepri ? |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm
|
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chuck Ha chuckh@vmware.com
What this PR does / why we need it:
The one line test addition ensures the code is exercised during the test. It's not super thorough testing though.
Note: I am mostly relying on the control plane e2e test for this functionality which is in an upcoming PR.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2092
related to #1756
/assign @ncdc @vincepri