-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ implement failure domain picking #2169
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go
Outdated
Show resolved
Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really two issues. One requires documentation for infrastructure providers saying that if they decide to add support for failure domains then the provider also needs to update the InfraMachines with their existing failure domain as the machine-controller in cluster-api would have no way to figure out which failure domain the machine lives in. The second part is having the machine controller copy the infra machine failure domain into the machine. I'll open these issues later on. |
sgtm, just wanted to make sure we don't drop tracking for it :) |
5f05777
to
0f904d5
Compare
Signed-off-by: Chuck Ha <chuckh@vmware.com>
0f904d5
to
205dd64
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Signed-off-by: Chuck Ha chuckh@vmware.com
What this PR does / why we need it:
This PR adds failure domain picking to the KubeadmControlPlane. There is no change to logic if failure domain is not defined. If a failure domain is defined then the KubeadmControlPlane controller will evenly distribute machines across all defined failure domains.
This is a naive approach. Please see #2131 for more details.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2131
Related to #1756
/assign @detiber