-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ KubeadmControlPlane upgrades #2238
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
😍 |
😍 i have never been more excited |
This looks great so far, want to fix the tests, merge this and then work on the TODOs? |
Works for me, went ahead and removed the draft status of the PR and added fixes for the broken tests. |
@detiber the capd-e2es are showing an interesting failure.
|
@chuckha indeed, starting to dig into that error now :) |
@chuckha test issue is resolved, I had to switch the |
/lgtm awesome start |
What this PR does / why we need it:
Enables KubeadmControlPlane upgrades
Related to: #1756