Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ KubeadmControlPlane upgrades #2238

Merged
merged 1 commit into from
Feb 13, 2020
Merged

✨ KubeadmControlPlane upgrades #2238

merged 1 commit into from
Feb 13, 2020
+188 −51

Conversation

detiber
Copy link
Member

@detiber detiber commented Jan 31, 2020

What this PR does / why we need it:

Enables KubeadmControlPlane upgrades

Related to: #1756

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 31, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020
@chuckha
Copy link
Contributor

chuckha commented Jan 31, 2020

😍
/assign

@rudoi
Copy link
Contributor

rudoi commented Jan 31, 2020

😍 i have never been more excited
/assign

@ncdc ncdc added this to the v0.3.0 milestone Feb 3, 2020
@vincepri vincepri modified the milestones: v0.3.0, v0.3.0-rc.0 Feb 12, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2020
@chuckha
Copy link
Contributor

chuckha commented Feb 13, 2020

This looks great so far, want to fix the tests, merge this and then work on the TODOs?

@detiber detiber marked this pull request as ready for review February 13, 2020 18:11
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2020
@detiber
Copy link
Member Author

detiber commented Feb 13, 2020

want to fix the tests, merge this and then work on the TODOs?

Works for me, went ahead and removed the draft status of the PR and added fixes for the broken tests.

@chuckha
Copy link
Contributor

chuckha commented Feb 13, 2020

@detiber the capd-e2es are showing an interesting failure.

          KubeadmControlPlane.controlplane.cluster.x-k8s.io "test-0" is invalid: spec.upgradeAfter: Invalid value: "null": spec.upgradeAfter in body must be of type string: "null"�[0m

@detiber
Copy link
Member Author

detiber commented Feb 13, 2020

@chuckha indeed, starting to dig into that error now :)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2020
@detiber
Copy link
Member Author

detiber commented Feb 13, 2020

@chuckha test issue is resolved, I had to switch the UpgradeAfter field to a pointer to satisfy apimachinery validation with it being optional.

@chuckha
Copy link
Contributor

chuckha commented Feb 13, 2020

/lgtm

awesome start

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit af05424 into kubernetes-sigs:master Feb 13, 2020
@fiunchinho fiunchinho mentioned this pull request Mar 8, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuckha chuckha Awaiting requested review from chuckha

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@chuckha chuckha

@rudoi rudoi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.0-rc.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@detiber @k8s-ci-robot @chuckha @rudoi @ncdc @vincepri