Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏃 Update the version of conversion-gen we are using #2247

Merged
merged 1 commit into from
Feb 3, 2020
Merged

🏃 Update the version of conversion-gen we are using #2247

merged 1 commit into from
Feb 3, 2020

Conversation

detiber
Copy link
Member

@detiber detiber commented Feb 3, 2020 •
edited
Loading

What this PR does / why we need it:

Updates the version of conversion-gen to ensure that we get the same comments whether run inside or outside of the GOPATH

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2020
@k8s-ci-robot k8s-ci-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 3, 2020
@detiber detiber changed the title 🏃 Fix arguments to conversion-gen when run outside of GOPATH 🏃 Update the version of conversion-gen we are using Feb 3, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 3, 2020
detiber
detiber commented Feb 3, 2020
View reviewed changes
test/infrastructure/docker/hack/update-deps.sh
@@ -1,29 +0,0 @@
#!/usr/bin/env bash
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a second way to update deps in capd aside from the make modules target

test/infrastructure/docker/hack/verify-deps.sh
@@ -1,50 +0,0 @@
#!/usr/bin/env bash
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a second way to verify modules outside of the make verify-modules target

test/infrastructure/docker/hack/verify-all.sh
failure $? "verify-deps.sh" "${out}"
cd "${REPO_PATH}" || exit
fi

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes the secondary module verification in favor of the make verify target, which already includes the verify-modules target.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@detiber
Copy link
Member Author

detiber commented Feb 3, 2020

/test pull-cluster-api-verify

@detiber detiber force-pushed the FixConversionGen branch 5 times, most recently from cda36a3 to b55acad Compare February 3, 2020 21:29
@detiber
Copy link
Member Author

detiber commented Feb 3, 2020

/assign @randomvariable

vincepri
vincepri approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit f208101 into kubernetes-sigs:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@chuckha chuckha Awaiting requested review from chuckha

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@randomvariable randomvariable

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@detiber @k8s-ci-robot @vincepri @randomvariable