✨Validates CoreDNS version update #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
vincepri
reviewed
Mar 18, 2020
controlplane/kubeadm/api/v1alpha3/kubeadm_control_plane_webhook.go
Outdated
Show resolved
Hide resolved
gab-satchi
force-pushed
the
2620-kcp-coredns-validation
branch
from
2f8c29f
to
fc63fde
Compare
- Skips validation if ClusterConfiguration undefined - Skips validation if previous version undefined
gab-satchi
force-pushed
the
2620-kcp-coredns-validation
branch
from
fc63fde
to
ceb528c
Compare
k8s-ci-robot
added
size/L
vincepri
reviewed
Mar 18, 2020
vincepri
reviewed
Mar 18, 2020
vincepri
approved these changes
Mar 18, 2020
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gab-satchi, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-cluster-api-capd-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR validates CoreDNS upgrade compatibility in the KCP webhook. It utilizes a function in the coredns-migration library that will compare two versions and determine if it can be upgraded from one to the other.
Which issue(s) this PR fixes
Fixes #2620