⚠️ util.{Machine,Cluster}ToInfrastructureMapFunc should exclude version when parsing object references

[jan-est]

This bugfix will fix the matching issue discussed in 2775 using match on group kind and not version in.

[k8s-ci-robot]

Hi @jan-est. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JoelSpeed]

Had a dig through the code to properly understand what's going on here, what used to happen is that you could have two versions for your CRD (eg v1alpha2 and v1alpha3), except if you updated the CRD as a v1alpha2 and the controller is expecting resources of v1alpha3 this wouldn't cause a reconcile? Whereas with this change you will reconcile the CRD no matter which version the event was triggered against? And that's fine cause conversion will make it so the controller can load any "version" as it were as the version it expects

[vincepri]

@JoelSpeed that is correct, if you had two different versions on the same contract the objects won't be reconciled properly. Having reconciliation on objects with different API versions is fine because of conversion as you mentioned.

[JoelSpeed]

In which case, everything looks good here :)

/lgtm

[vincepri]

/retitle ⚠️ util.{Machine,Cluster}ToInfrastructureMapFunc should exclude version when parsing object references

[vincepri]

/ok-to-test

[vincepri]

/milestone v0.3.3
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan-est, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment