-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support modifying spec.kubeadmConfigSpec.clusterConfiguration.imageRepository #2794
Conversation
/milestone v0.3.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/assign @ncdc
one very minor comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benmoss, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
linter is asking to create a const
|
Reviewing now |
lgtm pending squash |
…pository - Update kube-proxy and coreDNS images - Allow modification in webhook
3f74086
to
e3e8630
Compare
/lgtm |
What this PR does / why we need it:
Allows users to update the global image registry after having created a cluster.
Which issue(s) this PR fixes
Fixes #2777
/assign @vincepri