🐛 KCP should update Kubeadm config map when setting imageRepository
#2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/milestone v0.3.3 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benmoss, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retitle 🐛 KCP should update Kubeadm config map when setting |
k8s-ci-robot
changed the title
imageRepository
benmoss
changed the title
imageRepositoryimageRepository
|
@k8s-ci-robot hates emojis |
yastij
reviewed
Mar 27, 2020
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
benmoss
commented
Mar 27, 2020
vincepri
reviewed
Mar 27, 2020
benmoss
force-pushed
the
update-image-repo
branch
from
a43711f
to
5213120
Compare
k8s-ci-robot
removed
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
benmoss
force-pushed
the
update-image-repo
branch
from
5213120
to
bedda68
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes issues arising when a user specifies a global
imageRegistryin theirclusterConfiguration. We weren't updating the kubeadm configmap and so when we spun up new nodes kubeadm would still pull from the default registry.Which issue(s) this PR fixes
Fixes #2805