🐛 Ensure that capd tests always clean up the kind cluster #2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Having to abuse variable scoping a little bit, but otherwise would have to change framework.InitManagementCluster and maybe add another method to the interface. This also aggregates the log errors so that if one errors it doesn't prevent the rest from still attempting. Worst case they all fail but we still get one error.
|
/milestone v0.3.4 |
vincepri
approved these changes
Apr 15, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benmoss, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
lgtm form my side. |
|
/test pull-cluster-api-capd-e2e |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Ensure that we always delete the kind cluster created by the e2e suite. The problem is that
InitManagementClusterdoesn't return errors, it uses Gomega assertions, so if an error occurs after the cluster is created it will immediately return from theBeforeSuitebeforemgmtis assigned.Because of the
NewManagementClusterFnfeature I was able to abuse variable scoping a little bit to work around this, but otherwise would have to change framework.InitManagementCluster and maybe add another method to the interface. It definitely isn't the cleanest solution right now.This also aggregates the log errors so that if one errors it doesn't prevent the rest from still attempting. Worst case they all fail but we still get one error.
Which issue(s) this PR fixes:
Fixes #2881
/assign @fabriziopandini