-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Adds tolerations for cert-manager fixing issues with single node management clusters #3034
🐛 Adds tolerations for cert-manager fixing issues with single node management clusters #3034
Conversation
Hi @voor. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
@voor Will wait for @fabriziopandini to weigh in on the issue so that we better understand the use case. But for this PR you'll need to run |
/ok-to-test |
As per comments on the issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run make generate-bindata
.
/milestone v0.3.6 |
Run required command.
10ebeed
to
694b485
Compare
Reviewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri, voor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Verified the changes worked. |
What this PR does / why we need it: Single node management clusters is a great way to provide a small Cluster API environment while using minimal resources for the control plane, that requires either good diligence around removing the taint from the masters (probably not recommended) or just adding the necessary toleration for NoSchedule on all the Cluster API services. They already exist on most CAPI components and CAPI providers, so this just adds them to cert manager as well.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3033