🐛Support KUBECONFIG env var file paths #3047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
wfernandes
commented
May 11, 2020
| // These tests are emulating the files passed in via KUBECONFIG env var by | ||
| // injecting the file paths into the ClientConfigLoadingRules.Precedence | ||
| // chain. | ||
| func TestKUBECONFIGEnvVar(t *testing.T) { |
There was a problem hiding this comment.
I wrote the tests this way because I preferred to not override the KUBECONFIG env var. This method of injecting the precedence path is similar to what is done in kubernetes/client-go.
There was a problem hiding this comment.
nit.
Suggested change
| func TestKUBECONFIGEnvVar(t *testing.T) { | |
| func TestKubeconfigEnvVar(t *testing.T) { |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, wfernandes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-cluster-api-make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As described in the issue, this PR provides support for reading kubeconfig files as specified in the
KUBECONFIGenv var.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3012