-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add support for PKCS8 private keys in CA certs #3175
Conversation
Hi @maelk. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @detiber |
/ok-to-test |
ff755e3
to
9c766cd
Compare
/approve cancel not enough coffee this morning |
@detiber and @benmoss How do you propose to proceed with this change ? Should I change the APIs, and in that case, how do we ensure that go-apidiff would pass ? or should I try to keep the signature exactly the same for the existing functions ? The failures were here : https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/3175/pull-cluster-api-apidiff/1271334352977924096 |
go-apidiff isn't a merge-blocking job. I'll defer to @detiber for when we ignore it though, as I still don't entirely understand when it's okay 😄 |
OK, I think I finally grok why you added the extra functions. I think @detiber is correct, that if you change all the Maybe we want to use |
b7785b3
to
2660d94
Compare
Looks like another flake I added to my issue here #3197 /retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good, minor nit around the error being returned when all parsing attempts fail.
/lgtm |
@maelk thanks! |
WRT to api-diff failures, rif #3175 (comment) |
@detiber y'approve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor nits related to gomega matchers being used for the tests, otherwise I think this is ready to go.
@maelk thank you for tackling this and working through the implementation with us :)
/milestone v0.3.7 |
@maelk: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/approve |
1 similar comment
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benmoss, detiber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds support for PKCS8 formatted CA private key, to prevent failure when a user provides his own CA key using the commands from the CAPI book : https://cluster-api.sigs.k8s.io/tasks/certs/using-custom-certificates.html
A setup with those commands would otherwise fail.
Which issue(s) this PR fixes :
Fixes #3173