-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add machineset.yaml.template to vsphere example #318
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @k4leung4 /assign @roberthbailey |
/hold Until #316 is working |
apiVersion: "cluster.k8s.io/v1alpha1" | ||
kind: MachineSet | ||
metadata: | ||
name: karangoel-ms-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove karangoel from here: something like test-machineset-1
or vsphere-nodes
or something would make more sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
network: "" | ||
num_cpus: "2" | ||
memory: "2048" | ||
vm_template: "ubuntu-xenial-16.04-cloudimg-20180504" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is blank in https://github.com/kubernetes-sigs/cluster-api/blob/master/clusterctl/examples/vsphere/machines.yaml.template; should it be blank here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
memory: "2048" | ||
vm_template: "ubuntu-xenial-16.04-cloudimg-20180504" | ||
disk_label: "" | ||
disk_size: "10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
metadata: | ||
name: karangoel-ms-1 | ||
spec: | ||
replicas: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we default to 2 so that it's clear how this is different than individual machines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
/hold cancel |
/lgtm |
* Add machineset.yaml.template to vsphere example * cleanup manifest
What this PR does / why we need it: Add a sample machineset.yaml template