🌱Add cloned-from annotation to templated references #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
sethp-nr
reviewed
Jun 11, 2020
controlplane/kubeadm/api/v1alpha3/kubeadm_control_plane_types.go
Outdated
Show resolved
Hide resolved
sethp-nr
reviewed
Jun 11, 2020
vincepri
reviewed
Jun 11, 2020
controlplane/kubeadm/api/v1alpha3/kubeadm_control_plane_types.go
Outdated
Show resolved
Hide resolved
sethp-nr
reviewed
Jun 11, 2020
vincepri
reviewed
Jun 11, 2020
sethp-nr
reviewed
Jun 11, 2020
vincepri
reviewed
Jun 11, 2020
sethp-nr
reviewed
Jun 11, 2020
vincepri
reviewed
Jun 11, 2020
sedefsavas
force-pushed
the
kcp_annotation
branch
from
feed2ce
to
1ccd7a6
Compare
vincepri
reviewed
Jun 15, 2020
sethp-nr
reviewed
Jun 15, 2020
|
/test pull-cluster-api-test |
sedefsavas
force-pushed
the
kcp_annotation
branch
from
50cad85
to
c986a88
Compare
vincepri
reviewed
Jun 15, 2020
sedefsavas
force-pushed
the
kcp_annotation
branch
3 times, most recently
from
3383b12
to
b75abd2
Compare
|
@sedefsavas can you tag (emoji) the PR title accordingly? |
sedefsavas
changed the title
vincepri
reviewed
Jun 16, 2020
sedefsavas
force-pushed
the
kcp_annotation
branch
5 times, most recently
from
9f36e87
to
ea947b3
Compare
vincepri
reviewed
Jun 22, 2020
sedefsavas
force-pushed
the
kcp_annotation
branch
from
8408aee
to
80ba60f
Compare
ncdc
reviewed
Jun 23, 2020
ncdc
reviewed
Jun 23, 2020
ncdc
reviewed
Jun 23, 2020
sedefsavas
force-pushed
the
kcp_annotation
branch
from
80ba60f
to
1a3b0c2
Compare
ncdc
reviewed
Jun 23, 2020
|
1 outstanding comment to fix, then lgtm. Thanks!!! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
sedefsavas
force-pushed
the
kcp_annotation
branch
from
1a3b0c2
to
2bf3fb8
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
sedefsavas
force-pushed
the
kcp_annotation
branch
from
2bf3fb8
to
ca78075
Compare
k8s-ci-robot
removed
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
lgtm as well, thank you for all the work you've put into this |
|
/test pull-cluster-api-test |
vincepri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds infrastructure template that is cloned to create a machine as annotation to the machine object.
Fixes #3020