Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Set sideEffects:None for cert-manager MutatingWebhookConfiguration #3206

Merged
merged 1 commit into from
Jun 18, 2020
Merged

🐛 Set sideEffects:None for cert-manager MutatingWebhookConfiguration #3206

merged 1 commit into from
Jun 18, 2020

Conversation

wfernandes
Copy link
Contributor

What this PR does / why we need it:
This PR explicitly sets sideEffects: None to the MutatingWebhookConfiguration for cert-manager-webhook. This is also consistent with the ValidatingWebhookConfiguration for cert-manager-webhook.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3204

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2020
fabriziopandini
fabriziopandini reviewed Jun 18, 2020
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm apart a small question (probably a missing test)

cmd/clusterctl/client/cluster/cert_manager_test.go Show resolved Hide resolved
vincepri
vincepri reviewed Jun 18, 2020
View reviewed changes
cmd/clusterctl/config/assets/cert-manager.yaml
Comment on lines +2 to +7
# DIFFERENCES:
# 1. We've manually removed the ClusterRoleBinding cert-manager-leaderelection.
# See https://github.com/kubernetes-sigs/cluster-api/issues/2928
# See https://github.com/jetstack/cert-manager/pull/2207
# 2. Added `sideEffects: None` to MutatingWebhookConfiguration.
# See https://github.com/kubernetes-sigs/cluster-api/issues/3204
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I kinda wish we used kustomize to apply these patches, so they can be reproducible, oh well :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah...I agree. The patches would've also acted as the documentation instead of having these comments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vincepri Did you want me to create an issue for generating this asset file via kustomize?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not a huge problem though for now

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2020
@vincepri
Copy link
Member

/test pull-cluster-api-test

vincepri
vincepri approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @detiber @ncdc
for final approval
/milestone v0.3.7

@k8s-ci-robot k8s-ci-robot added this to the v0.3.7 milestone Jun 18, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2020
@detiber
Copy link
Member

detiber commented Jun 18, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 46bf40c into kubernetes-sigs:master Jun 18, 2020
@wfernandes wfernandes deleted the cert-manager-sideEffects branch June 18, 2020 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@vincepri vincepri vincepri approved these changes

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@ncdc ncdc

@detiber detiber

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.7
Development

Successfully merging this pull request may close these issues.

sideEffects for cert-manager mutating webhook is Unkown
6 participants
@wfernandes @vincepri @detiber @k8s-ci-robot @fabriziopandini @ncdc