Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add AZURE_ENVIRONMENT env var to azure instructions in quick start guide #3212

Merged
merged 1 commit into from
Jun 22, 2020
Merged

📖 Add AZURE_ENVIRONMENT env var to azure instructions in quick start guide #3212

merged 1 commit into from
Jun 22, 2020

Conversation

nader-ziada
Copy link
Contributor

What this PR does / why we need it:

  • This AZURE_ENVIRONMENT env var specifies the Azure cloud to use.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

will hold for the PR in capz adding this feature to merge kubernetes-sigs/cluster-api-provider-azure#649
/hold

@nader-ziada
Add AZURE_ENVIRONMENT env var to azure instructions
9b6fc5a 
 - this env var specifies the Azure cloud to use
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 18, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2020
vincepri
vincepri reviewed Jun 18, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @CecileRobertMichon

Is this a short term solution because of the lack of defaults?

@nader-ziada
Copy link
Contributor Author

@vincepri yes, comment on PR here: kubernetes-sigs/cluster-api-provider-azure#649 (comment)

@vincepri
Copy link
Member

Got it, thanks

@CecileRobertMichon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2020
@nader-ziada nader-ziada mentioned this pull request Jun 18, 2020
Merged
@wfernandes
Copy link
Contributor

/lgtm

vincepri
vincepri approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@vincepri
Copy link
Member

/milestone v0.3.7

@k8s-ci-robot k8s-ci-robot added this to the v0.3.7 milestone Jun 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2020
@vincepri
Copy link
Member

Seems the linked PR has merged, ok to unhold @CecileRobertMichon @nader-ziada ?

@nader-ziada
Copy link
Contributor Author

yes, PR in capz got merged today

@nader-ziada
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2020
@vincepri
Copy link
Member

/hold cancel

@vincepri
Copy link
Member

/test pull-cluster-api-test

@k8s-ci-robot k8s-ci-robot merged commit c550760 into kubernetes-sigs:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@moshloop moshloop Awaiting requested review from moshloop

Assignees

@wfernandes wfernandes

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.7
Development

Successfully merging this pull request may close these issues.
5 participants
@nader-ziada @vincepri @CecileRobertMichon @wfernandes @k8s-ci-robot