🌱 clusterctl move ClusterResourceSets #3243
Merged
+576
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
/milestone v0.3.7 |
k8s-ci-robot
added
the
needs-rebase
fabriziopandini
force-pushed
the
move-ClusterResourceSet
branch
from
771e8ee
to
9040843
Compare
k8s-ci-robot
added
size/XL
fabriziopandini
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
fabriziopandini
force-pushed
the
move-ClusterResourceSet
branch
from
9040843
to
088f89b
Compare
vincepri
approved these changes
Jul 7, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
sedefsavas
reviewed
Jul 7, 2020
| @@ -275,7 +275,7 @@ func getMoveSequence(graph *objectGraph) *moveSequence { | |||
| // NB. it is necessary to filter out nodes not belonging to a cluster because e.g. discovery reads all the secrets, | |||
There was a problem hiding this comment.
In L120, do we need to check control plane ready condition instead of clusterObj.Status.ControlPlaneReady ?
In my setup I don't see Status.controlPlaneReady anymore.
There was a problem hiding this comment.
It is required to install the CNI in order to get Status.controlPlaneReady
fabriziopandini
force-pushed
the
move-ClusterResourceSet
branch
from
088f89b
to
fbd8d9a
Compare
|
/test pull-cluster-api-e2e |
1 similar comment
|
/test pull-cluster-api-e2e |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR extends clusterctl move so it will manage to move the ClusterResourceSet objects defined in a namespace.
TL;DR of the changes: during the discovery phase that is executed before Move, we are identifying ClusterResourceSet and their descendants; those objects will be included in the move scope.
NB.
this PR will remain WIP until #3107 merges
/assign @vincepri
/assign @sedefsavas