🐛 Make KCP supporting external etcd #3298
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
fabriziopandini
force-pushed
the
kcp-external-etcd
branch
from
48f5303
to
7272e88
Compare
|
/cc zanghao2 |
|
@fabriziopandini: GitHub didn't allow me to request PR reviews from the following users: zanghao2. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-rebase
|
@vincepri is there an expected milestone for this PR? |
|
Let's rebase and re-review, I haven't had enough time to go through the PR. This can probably go in v0.3.9 /milestone v0.3.9 |
fabriziopandini
force-pushed
the
kcp-external-etcd
branch
from
d563742
to
a50d913
Compare
k8s-ci-robot
removed
the
needs-rebase
|
rebased |
util/secret/certificates.go
Outdated
| @@ -112,29 +113,53 @@ func NewCertificatesForInitialControlPlane(config *v1beta1.ClusterConfiguration) | |||
| } | |||
|
|
|||
| // NewCertificatesForJoiningControlPlane gets any certs that exist and writes them to disk | |||
| func NewCertificatesForJoiningControlPlane() Certificates { | |||
| return Certificates{ | |||
| func NewCertificatesForJoiningControlPlane(config *v1beta1.ClusterConfiguration) Certificates { | |||
There was a problem hiding this comment.
This is a breaking change, we should deprecate this function in favor of a different one
There was a problem hiding this comment.
@vincepri done
wondering if there is a way to avoid the WithConfig in the name of the new func once we deprecate this one...
fabriziopandini
force-pushed
the
kcp-external-etcd
branch
from
52fc5af
to
4d33438
Compare
|
@vincepri func renamed and commits squashed |
fabriziopandini
force-pushed
the
kcp-external-etcd
branch
from
4d33438
to
985c77f
Compare
fabriziopandini
force-pushed
the
kcp-external-etcd
branch
from
985c77f
to
494b8b1
Compare
|
LGTM. @detiber @randomvariable do you want to review / do you have time? |
|
👀 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
This PR makes KCP supporting external etcd. While investigating this issue I discovered that the CAPBK support for external etcd is broken for joining control-planes (original PR) because we are not managing a flexible list of certificates here.
Now this should be fixed, but in order to get this working we are preserving the ClusterConfiguration in all the KubeadmConfig generated by KCP, and this is a kind of duplicate of the machine annotation recently added.
I'm opening an issue to sort out a common approach.
Which issue(s) this PR fixes:
Fixes #3242