Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add CAPD control plane toleration #3320

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

benmoss
Copy link

@benmoss benmoss commented Jul 9, 2020

What this PR does / why we need it:
Adds a toleration to the CAPD manager deployment so that it can run on control plane nodes. I was trying to self-host a cluster with CAPD and was surprised to see that this deployment's pods were unable to be scheduled because it doesn't tolerate running on the control plane nodes.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 9, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 9, 2020
@vincepri
Copy link
Member

vincepri commented Jul 9, 2020

Please retitle to avoid the use of the word master

@ncdc
Copy link
Contributor

ncdc commented Jul 9, 2020

@benmoss even though the toleration key includes the word "master", would you mind adjusting the PR title, description and commit message to say "control plane" instead? Thanks!

@benmoss
Copy link
Author

benmoss commented Jul 9, 2020

Yeah I was thinking this would just be updated when #3279 was fixed. I'll retitle though.

@benmoss benmoss changed the title 🌱 Add CAPD master toleration 🌱 Add CAPD control plane toleration Jul 9, 2020
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/assign @ncdc
/milestone v0.3.x

@k8s-ci-robot k8s-ci-robot added this to the v0.3.x milestone Jul 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2020
@ncdc
Copy link
Contributor

ncdc commented Jul 15, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 34ac896 into kubernetes-sigs:master Jul 15, 2020
@k8s-ci-robot
Copy link
Contributor

@benmoss: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-make bed682c link /test pull-cluster-api-make

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@benmoss benmoss deleted the capd-tolerations branch July 15, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants