Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Ensure that etcd health check errors are logged in KCP #3336

Merged
merged 1 commit into from
Aug 28, 2020
Merged

🐛 Ensure that etcd health check errors are logged in KCP #3336

merged 1 commit into from
Aug 28, 2020

Conversation

Arvinderpal
Copy link
Contributor

What this PR does / why we need it:
The initial error returned for an etcd health check gets overwritten and is never logged.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 14, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @Arvinderpal. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 14, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 14, 2020
@Arvinderpal Arvinderpal changed the title 🐛 Ensure that etcd health check errors are logged 🐛 Ensure that etcd health check errors are logged in KCP Jul 14, 2020
@Arvinderpal
Copy link
Contributor Author

Arvinderpal commented Jul 14, 2020 •
edited
Loading

@sedefsavas PTAL

@sedefsavas
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 14, 2020
@sedefsavas
Copy link

@Arvinderpal make fails due to lint check: https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/3336/pull-cluster-api-make/1283447673436770304/build-log.txt

@Arvinderpal Arvinderpal mentioned this pull request Jul 17, 2020
Closed
@vincepri vincepri mentioned this pull request Jul 23, 2020
Merged
@Arvinderpal Arvinderpal force-pushed the kcp-log-etcd-errors branch 4 times, most recently from d6b40cc to 0cccc6f Compare July 23, 2020 20:13
@Arvinderpal
Copy link
Contributor Author

@sedefsavas @vincepri Tests are clean.

@Arvinderpal Arvinderpal force-pushed the kcp-log-etcd-errors branch 2 times, most recently from 07e7589 to 93797cb Compare July 28, 2020 18:42
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 28, 2020
sedefsavas
sedefsavas reviewed Aug 3, 2020
View reviewed changes
Copy link

@sedefsavas sedefsavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits. Otherwise LGTM.

controlplane/kubeadm/controllers/controller.go Outdated Show resolved Hide resolved
controlplane/kubeadm/controllers/controller.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2020
vincepri
vincepri approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/assign @ncdc @fabriziopandini

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 27, 2020
@fabriziopandini
Copy link
Member

/retest

@vincepri
Copy link
Member

/test pull-cluster-api-test

1 similar comment
@fabriziopandini
Copy link
Member

/test pull-cluster-api-test

@vincepri
Copy link
Member

Seems there are two other tests under KCP that are now failing

@vincepri
Copy link
Member

@Arvinderpal can you take a look?

@CecileRobertMichon
Copy link
Contributor

lgtm pending tests

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2020
@Arvinderpal
Copy link
Contributor Author

alright, so reconcileHealth() treats the case of unhealthy etcd differently from unhealthy controlplane. the unit test now reflects this.

@vincepri

@CecileRobertMichon
Copy link
Contributor

@Arvinderpal this fixes #3519, correct? If so please add to PR description

@vincepri vincepri mentioned this pull request Aug 28, 2020
Closed
@vincepri
Copy link
Member

It partially does, the first error is still not returned, but logged now. I don't think we should necessarily go in backoff loop for the first error, given that there might be transient issues that are resolved sooner than the backoff retries

@CecileRobertMichon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0a5f988 into kubernetes-sigs:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc ncdc left review comments

@vincepri vincepri vincepri approved these changes

@sedefsavas sedefsavas sedefsavas left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@ncdc ncdc

@fabriziopandini fabriziopandini

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.9
Development

Successfully merging this pull request may close these issues.
7 participants
@Arvinderpal @k8s-ci-robot @sedefsavas @vincepri @fabriziopandini @CecileRobertMichon @ncdc