🌱 [e2e framework] Fix race condition when testing ClusterResourceSetBinding #3394
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
/assign @sedefsavas |
| } | ||
|
|
||
| if err := input.ClusterProxy.GetClient().Get(ctx, types.NamespacedName{Name: resource.Name, Namespace: input.ClusterResourceSet.Namespace}, configSource); err != nil { | ||
| continue |
There was a problem hiding this comment.
@sedefsavas I'm not overly familiar with these tests, so I wasn't sure if it was intentional that we continued through the loop when the Get for the related Secret/ConfigMap returned an error, so I kept the existing behavior. I'm wondering if this should return false here instead, though.
There was a problem hiding this comment.
If the resource is missing, CRS will not requeue but retry at each reconcile, because this is not an error. So, we are only interested in seeing the resources that exist to be applied by CRS.
There was a problem hiding this comment.
Can we add a comment to that effect?
There was a problem hiding this comment.
This test is going to be removed totally with this PR: #3332
There was a problem hiding this comment.
Are we planning to merge that in v0.3.8, or later? If later, I'd prefer to have a comment just in case it stays around for longer
There was a problem hiding this comment.
There are changes in providers as well and all need to go in at once.
We are waiting CAPA's next release, there is a change there we need to wait.
|
/milestone v0.3.8 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
removed
the
lgtm
|
/retest |
…ding - Also, update commment on test/framework/clusterresourceset_helpers.go
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-cluster-api-e2e e2e failures look like flakes that are not related to this PR: /test pull-cluster-api-e2e |
|
/test pull-cluster-api-e2e |
What this PR does / why we need it:
Attempts to fix a race condition in the test framework related to ClusterResourceSetBindings