🌱 MHC should not remediate paused machines #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
vincepri
reviewed
Aug 3, 2020
detiber
reviewed
Aug 3, 2020
benmoss
force-pushed
the
mhc-paused-machines
branch
from
4b9fd22
to
72f0d75
Compare
k8s-ci-robot
added
size/XS
|
/test pull-cluster-api-verify |
|
changes lgtm pending @vincepri's request for a test |
|
Do we actually want to mark it with |
benmoss
force-pushed
the
mhc-paused-machines
branch
from
72f0d75
to
ec88094
Compare
|
I think that's the right thing, so I've updated the implementation to do so |
k8s-ci-robot
added
size/L
|
/milestone v0.3.9 |
|
/test pull-cluster-api-test |
vincepri
approved these changes
Aug 4, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
|
/test pull-cluster-api-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Right now the MHC controller only checks if the MHC object itself or the Cluster is paused. It seems reasonable users would expect that pausing a machine would also pause remediation on it.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3421
In #3108 I unintentionally changed the logic here to return when we encounter an error patching one of the machines, instead of the prior behavior of continuing to try to remediate all of the machines before returning an error collection. This also brings back that logic.