Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Document clusterctl version support #3449

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR documents version support for clusterctl

Which issue(s) this PR fixes:
Fixes #3090

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 4, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 4, 2020
Comment on lines 83 to 85
It is strongly recommended using a version of [clusterctl](../clusterctl/overview.md) that exactly matches the version
of the Cluster API core provider; in case of upgrades, clusterctl should be upgraded first and used to upgrade
all the other components.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what we're trying to communicate here, do we want users to upgrade clusterctl to the latest available version all the time?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, IMO this is the safest approach: upgrade clusterctl first, then use the latest clusterctl to upgrade other components

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It is strongly recommended using a version of [clusterctl](../clusterctl/overview.md) that exactly matches the version
of the Cluster API core provider; in case of upgrades, clusterctl should be upgraded first and used to upgrade
all the other components.
It is strongly recommended using the latest version of [clusterctl](../clusterctl/overview.md) before attempting to upgrade your clusters.

How about something like this? I'd also open an issue if we don't have one already to have ways in clusterctl to check for its latest version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking back to this might be I have misunderstood the original question because the consideration does not apply to upgrades only .

I have in mind some recent use cases of uses trying to init a cluster with version 0.3.7 but using an older version of clusterctl, and failing due to the changes for envsubst; I do expect might happen in the near future as well, e.g. for the changes on cert-manager, or for the changes on the move logic.

This is why IMO the version of clusterctl should always be >= to the version of CAPI installed in the cluster (and as corollary, clusterctl should be updated before all the other components)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Ideally, the user should always update to the latest version of clusterctl before doing any operations in order to avoid unintended side effects.
We had a discussion regarding clusterctl doing a version check (see slack thread).

I can create an issue regarding clusterctl doing a version check.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created this issue regarding above: #3466

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have aligned the doc to the issue above, please PTAL

@fabriziopandini fabriziopandini changed the title 📖 Document clusterctl version support 📖 Document clusterctl version support Aug 10, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2020
@wfernandes
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2020
@randomvariable
Copy link
Member

/lgtm

@wfernandes
Copy link
Contributor

Looks like this could use an /approve

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2020
@vincepri
Copy link
Member

/milestone v0.3.9

@k8s-ci-robot k8s-ci-robot added this to the v0.3.9 milestone Aug 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5c3e993 into kubernetes-sigs:master Aug 18, 2020
@fabriziopandini fabriziopandini deleted the improve-version-support-doc branch August 19, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document clusterctl version support
6 participants