-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 [e2e] add debug output for deployment failures #3468
🌱 [e2e] add debug output for deployment failures #3468
Conversation
/assign @CecileRobertMichon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/assign @fabriziopandini @sedefsavas
/milestone v0.3.9
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit. Otherwise LGTM.
Thanks @mboersma |
32af37a
to
2793d9d
Compare
2793d9d
to
9455243
Compare
/retest |
/lgtm |
What this PR does / why we need it:
Pretty-prints the JSON representation of a deployment when
WaitForDeploymentsAvailable
fails an e2e test.We use these framework methods downstream in CAPZ and could use more context when debugging e2e failures. I'd like to follow on by also printing relevant Kubernetes events in
DescribeFailedDeployment
, but wanted to keep this simple.Which issue(s) this PR fixes:
N/A, but see kubernetes-sigs/cluster-api-provider-azure#807