Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 [clusterctl] Allow single image override #3480

Merged
merged 1 commit into from
Aug 21, 2020
Merged

🌱 [clusterctl] Allow single image override #3480

merged 1 commit into from
Aug 21, 2020

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR allow to configure image overrides for a single image in a component (vs configuring overrides for all the image in a component) e.g.

images:
   infrastructure-docker/kube-rbac-proxy:
      tag: myCustomBuild

Which issue(s) this PR fixes:
Fixes #3469

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 13, 2020
@fabriziopandini
Copy link
Member Author

/assign @wfernandes

@wfernandes
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2020
@fabriziopandini
Copy link
Member Author

/assign @vincepri

@vincepri
Copy link
Member

Squash?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2020
@fabriziopandini
Copy link
Member Author

Squash done!

vincepri
vincepri approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/milestone v0.3.9

@k8s-ci-robot k8s-ci-robot added this to the v0.3.9 milestone Aug 21, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit bb203e4 into kubernetes-sigs:master Aug 21, 2020
@fabriziopandini fabriziopandini deleted the allow-single-image-override branch August 28, 2020 11:49
@fabriziopandini fabriziopandini mentioned this pull request Sep 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@randomvariable randomvariable Awaiting requested review from randomvariable

Assignees

@wfernandes wfernandes

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.9
Development

Successfully merging this pull request may close these issues.

Allow updating just the provider image tag with clusterctl config file's images section
4 participants
@fabriziopandini @wfernandes @vincepri @k8s-ci-robot