-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Update concepts docs around v1alpha3 #3522
📖 Update concepts docs around v1alpha3 #3522
Conversation
Hi @joshrosso. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How comes the management cluster SVG has been updated? I would expect to see plantuml changes accompanying any update to that SVG
/ok-to-test |
@JoelSpeed : The PlantUML was not edited because this |
docs/book/src/user/concepts.md
Outdated
As of v1alpha2, __Machine-Based__ is the only control plane type that Cluster API supports. | ||
As of v1alpha2, __Machine-Based__ is the only control plane type that Cluster API supports. | ||
|
||
As of v1alpha3, the default provider uses kubeadm to bootstrap the control plane. It exposes the configuration via the `kubeadmcontrolplane` object. The controller, `capi-kubeadm-control-plane-controller-manager`, can then create Machine and BootstrapConfig objects based on the requested replicas in the `kubeadmcontrolplanes` object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"As of v1alpha3, the default provider uses kubeadm to bootstrap the control plane"
is kind of misleading because in a sense, we always were using kubeadm to bootstrap the control plane, there was just no "stateful set" type of controller to manage it - you'd create individual machines with kubeadmconfigs and manage the overall control plane yourself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@randomvariable, great point.
The latter sentence around Kubeadmcontrolplane
and capi-kubeadm-control-plane-controller-manager
was more what I was trying to qualify v1alpha3
🤔. Let me move that qualifier around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@randomvariable, watchu think about this revision?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think that works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lgtm pending squash |
callout kubeadmcp provider as v1alpha3 This upgrades the diagram to include the control plane and machinehealthcheck objects. It also adds some context around the inner-workings of kubeadmcontrolplane.
@fabriziopandini squashed |
/lgtm |
What this PR does / why we need it:
This upgrades the diagram to include the control plane and machinehealthcheck objects. It also adds some context around the inner-workings of kubeadmcontrolplane.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3097