Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Updated upgrade documentation #3530

Merged

Conversation

randomvariable
Copy link
Member

@randomvariable randomvariable commented Aug 26, 2020

What this PR does / why we need it:

  • Retitle upgrade task to be more specific wrt to upgrading Cluster API versions with better SEO URL (with redirect (bumped to mdbook 0.4.2 for this)).

  • Added upgrading-clusters.md to tasks, referencing relevant documentation.

  • Added statement to version skew docs about order of upgrading management vs. workload clusters.

  • Remove v0.3 beta & release candidate language.

  • Consolidate upgrade documentation.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3091

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 26, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 26, 2020
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm, only few suggestions but nothing blocking

docs/book/src/tasks/upgrading-clusters.md Outdated Show resolved Hide resolved
docs/book/src/tasks/upgrading-clusters.md Outdated Show resolved Hide resolved
docs/book/src/SUMMARY.md Outdated Show resolved Hide resolved
docs/book/src/SUMMARY.md Outdated Show resolved Hide resolved
docs/book/src/tasks/upgrading-cluster-api-versions.md Outdated Show resolved Hide resolved
docs/book/src/tasks/upgrading-cluster-api-versions.md Outdated Show resolved Hide resolved
@randomvariable
Copy link
Member Author

Cool, thanks for these. will update in a mo.

@randomvariable
Copy link
Member Author

/test pull-cluster-api-e2e

@randomvariable
Copy link
Member Author

/retest

docs/book/src/tasks/upgrading-clusters.md Outdated Show resolved Hide resolved
docs/book/src/reference/versions.md Outdated Show resolved Hide resolved
@randomvariable
Copy link
Member Author

/test pull-cluster-api-test

@vincepri
Copy link
Member

/milestone v0.3.10

@k8s-ci-robot k8s-ci-robot added this to the v0.3.10 milestone Aug 28, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2020
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minors, but overall lgtm

docs/book/src/tasks/upgrading-clusters.md Show resolved Hide resolved
docs/book/src/tasks/upgrading-clusters.md Outdated Show resolved Hide resolved
docs/book/src/tasks/upgrading-clusters.md Outdated Show resolved Hide resolved
docs/book/src/tasks/upgrading-cluster-api-versions.md Outdated Show resolved Hide resolved
@vincepri
Copy link
Member

@randomvariable Do you have some time today to rebase + fix comments?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2020
@randomvariable randomvariable force-pushed the upgrade-statement branch 2 times, most recently from 4097fd4 to 9621292 Compare September 28, 2020 11:06
Retitle upgrade task to be more specific wrt to upgrading
Cluster API versions with better SEO URL (with redirect).

Added upgrading-clusters.md to tasks, referencing relevant
documentation.

Added statement to version skew docs about order of upgrading
management vs. workload clusters.

Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@randomvariable
Copy link
Member Author

Replaced the out of date text @ncdc and @fabriziopandini . Take a look at your leisure. Not urgent.

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2020
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit 05da807 into kubernetes-sigs:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document management/workload cluster upgrade order
7 participants