-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Updated upgrade documentation #3530
📖 Updated upgrade documentation #3530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, only few suggestions but nothing blocking
Cool, thanks for these. will update in a mo. |
521f3f0
to
46d54e4
Compare
/test pull-cluster-api-e2e |
/retest |
aa36f42
to
4d2015c
Compare
/test pull-cluster-api-test |
/milestone v0.3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minors, but overall lgtm
@randomvariable Do you have some time today to rebase + fix comments? |
4d2015c
to
5ff4807
Compare
4097fd4
to
9621292
Compare
Retitle upgrade task to be more specific wrt to upgrading Cluster API versions with better SEO URL (with redirect). Added upgrading-clusters.md to tasks, referencing relevant documentation. Added statement to version skew docs about order of upgrading management vs. workload clusters. Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
9621292
to
b0e6ca3
Compare
Replaced the out of date text @ncdc and @fabriziopandini . Take a look at your leisure. Not urgent. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Retitle upgrade task to be more specific wrt to upgrading Cluster API versions with better SEO URL (with redirect (bumped to mdbook 0.4.2 for this)).
Added upgrading-clusters.md to tasks, referencing relevant documentation.
Added statement to version skew docs about order of upgrading management vs. workload clusters.
Remove v0.3 beta & release candidate language.
Consolidate upgrade documentation.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3091