-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Tilt should use a supported kustomize version #3551
🐛 Tilt should use a supported kustomize version #3551
Conversation
Fixes an issue where Tilt would use whatever Kustomize version was available in the user's PATH. Given that there have been breaking changes in kustomize itself, we now instead build and use our own version that's provided in hack/tools. Signed-off-by: Vince Prignano <vincepri@vmware.com>
/test pull-cluster-api-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-cluster-api-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test pull-cluster-api-e2e |
/retest |
/retest |
What this PR does / why we need it:
Fixes an issue where Tilt would use whatever Kustomize version was
available in the user's PATH. Given that there have been breaking
changes in kustomize itself, we now instead build and use our own
version that's provided in hack/tools.
/milestone v0.3.9
/assign @CecileRobertMichon @fabriziopandini @ncdc