Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add LogCollector to E2E framework #3580

Merged
merged 1 commit into from
Sep 3, 2020
Merged

🌱 Add LogCollector to E2E framework #3580

merged 1 commit into from
Sep 3, 2020

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR adds a LogCollector to the E2E framework.

The LogCollector is a pluggable component that accesses machines in a workload cluster and collect logs, and each provider can inject the specific implementation.

This PR includes the implementation for CAPD.

Which issue(s) this PR fixes:
Fixes #3344

/assign @randomvariable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 2, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 2, 2020
@fabriziopandini
Copy link
Member Author

/milestone v0.3.10

@k8s-ci-robot k8s-ci-robot added this to the v0.3.10 milestone Sep 2, 2020
@ncdc
Copy link
Contributor

ncdc commented Sep 2, 2020

Doesn't have to be in this PR, but I think we also need the pod logs from the workload cluster.

@vincepri
Copy link
Member

vincepri commented Sep 2, 2020

/retest

@sedefsavas
Copy link

/test pull-cluster-api-e2e

3 similar comments
@sedefsavas
Copy link

/test pull-cluster-api-e2e

@sedefsavas
Copy link

/test pull-cluster-api-e2e

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e

@fabriziopandini
Copy link
Member Author

/hold
I would like to experiment a little bit on logs structure

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 3, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2020
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e

@fabriziopandini
Copy link
Member Author

Comment addressed + squashed commits
Now the logs structure is cleaner IMO, because all the clusters use the specName as a prefix and the self-hosted cluster now contains both the logs for the management cluster and the workload cluster
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 3, 2020 •
edited
Loading

@fabriziopandini: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-apidiff 5037a94 link /test pull-cluster-api-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@randomvariable
Copy link
Member

randomvariable commented Sep 3, 2020 •
edited
Loading

Just had a browse through of the artifacts in the last e2e job

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2020
@randomvariable
Copy link
Member

/assign @vincepri
for approval and override

vincepri
vincepri approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/override pull-cluster-api-test
/approve

@k8s-ci-robot
Copy link
Contributor

@vincepri: Overrode contexts on behalf of vincepri: pull-cluster-api-test

In response to this:

/override pull-cluster-api-test
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit a260cb4 into kubernetes-sigs:master Sep 3, 2020
@fabriziopandini fabriziopandini deleted the e2e-get-machine-logs branch September 9, 2020 08:20
This was referenced Sep 15, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@randomvariable randomvariable

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.10
Development

Successfully merging this pull request may close these issues.

Collect cloud init logs/machine logs for E2E workload clusters
6 participants
@fabriziopandini @ncdc @vincepri @sedefsavas @k8s-ci-robot @randomvariable