-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Stop test suite when a capi e2e test fails #3585
Conversation
174c153
to
1125aa5
Compare
/test pull-cluster-api-e2e |
/lgtm |
/remove lgtm |
/lgtm cancel |
1125aa5
to
2acfb0c
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds the ginkgo
--failFast
flag to our ginkgo run.For Reviewers
However, if our test suites are run in parallel, then I don't believe a failing test will stop all the parallel runs.
If you'd like to verify this,
Makefile
setGINKGO_NODES
andGINKGO_ARGS
,make test-e2e
.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3571