Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Stop test suite when a capi e2e test fails #3585

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

wfernandes
Copy link
Contributor

What this PR does / why we need it:
This PR adds the ginkgo --failFast flag to our ginkgo run.

For Reviewers
However, if our test suites are run in parallel, then I don't believe a failing test will stop all the parallel runs.
If you'd like to verify this,

  1. in the root Makefile set GINKGO_NODES and GINKGO_ARGS,
     .PHONY: test-e2e
     test-e2e: ## Run the e2e tests
           #The `-stream` flag will stream output from all parallel nodes in real-time, prepending each log line with the node # that emitted it.
           GINKGO_NODES=3 GINKGO_ARGS="--failFast -stream" $(MAKE) -C test/e2e run
  2. Then run make test-e2e.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3571

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 2, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2020
@wfernandes
Copy link
Contributor Author

/test pull-cluster-api-e2e

@randomvariable
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2020
@randomvariable
Copy link
Member

/remove lgtm

test/e2e/Makefile Outdated Show resolved Hide resolved
@randomvariable
Copy link
Member

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2020
@randomvariable
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2020
@fabriziopandini
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5164a1f into kubernetes-sigs:master Sep 7, 2020
@wfernandes wfernandes deleted the e2e-fail-fast branch September 8, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail fast on all ginkgo e2e CI test jobs
4 participants