🌱 Tiltfile: Parameterize kustomize and main.go for providers #3604
Conversation
In some cases the providers listed might not have a ./config
folder, or the config should not be applied. This commit allows
the user to prevent running kustomize on the ./config folder
by setting the `kustomize_config` boolean field in the
tilt-provider.json file. For example:
```json
{
"name": "aws",
"config": {
"kustomize_config": false,
"image": "gcr.io/k8s-staging-cluster-api-aws/cluster-api-aws-controller",
"live_reload_deps": [
"main.go", "go.mod", "go.sum", "api", "cmd", "controllers", "pkg"
]
}
}
```
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @maelk. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
k8s-ci-robot
added
the
size/M
|
/assign @justinsb |
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
k8s-ci-robot
removed
the
needs-ok-to-test
k8s-ci-robot
added
the
lgtm
|
It seems there are som lint issues to be fixed |
In some cases (if built with an older operator-sdk version for example)
there might not be a main.go at the root of the repository of a
provider. This change allows the user to specify its go main file with
the option "go_main" in the tilt provider file, such as
```json
{
"name": "bmo",
"config": {
"kustomize_config": false,
"go_main": "cmd/manager/main.go",
"image": "quay.io/metal3-io/baremetal-operator",
"live_reload_deps": [
"cmd", "pkg"
]
}
}
```
k8s-ci-robot
removed
the
lgtm
|
@fabriziopandini thank you for the note. I fixed the format. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
This comes from a need in Metal3. The CAPM3 provider contains for now three controllers, each of them in a separate repository. Only the main repository (the CAPM3 controller) contains a ./config folder that should be applied, and that includes the the two other controllers. It is currently possible to develop CAPM3 using CAPI tiltfile but that limits us to working with CAPM3 only, as the two other controllers repositories are not considered. If the Tiltfile was not trying to build the ./config folder of all providers, those two other repositories could be given as additional providers to allow development there too. In addition, when the provider is not built using Kubebuilder, but an old version of operator-sdk for example, the main.go file is not located at the root of the repository.
This PR adds a configuration field to be able to disable the kustomize step of the Tiltfile. It allows the user to prevent running kustomize on the ./config folder by setting the
kustomize_configboolean field in the tilt-provider.json file. It also allows the user to provide a specific main.go file for the provider. For example:{ "name": "bmo", "config": { "kustomize_config": false, "go_main": "cmd/manager/main.go", "image": "quay.io/metal3-io/baremetal-operator", "live_reload_deps": [ "cmd", "pkg" ] } }