Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clusterctl test framework: Restore CNIManifestPath to struct for API compat #3608

Merged

Conversation

randomvariable
Copy link
Member

Parity with Cluster API 0.3.8

Signed-off-by: Naadir Jeewa jeewan@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3607

Parity with Cluster API 0.3.8

Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 8, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 8, 2020
@randomvariable randomvariable changed the title clusterctl: Restore CNIManifestPath to struct for API compat clusterctl test framework: Restore CNIManifestPath to struct for API compat Sep 8, 2020
@randomvariable
Copy link
Member Author

/test pull-cluster-api-test

@wfernandes
Copy link
Contributor

/assign @sedefsavas

@sedefsavas
Copy link

cc @fabriziopandini

@sedefsavas
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2020
@fabriziopandini
Copy link
Member

/approve
to restoring the possibility to specify a CMI manifest path without using CRS.

@sedefsavas, should kubernetes-sigs/cluster-api-provider-aws#1816 switch CAPA to use CRS (so this field won't be used anymore)?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2020
@randomvariable
Copy link
Member Author

/test pull-cluster-api-test

@sedefsavas
Copy link

@fabriziopandini Yes after that PR is in, it will be the case for CAPA but this PR is fine too to revert an undocumented breaking change, in the next release we can document and do this change.

@sedefsavas, should kubernetes-sigs/cluster-api-provider-aws#1816 switch CAPA to use CRS (so this field won't be used anymore)?

@k8s-ci-robot k8s-ci-robot merged commit ca61132 into kubernetes-sigs:master Sep 8, 2020
@vincepri
Copy link
Member

vincepri commented Sep 9, 2020

/milestone v0.3.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking API change in clusterctl for 0.3.9
6 participants