-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clusterctl test framework: Restore CNIManifestPath to struct for API compat #3608
clusterctl test framework: Restore CNIManifestPath to struct for API compat #3608
Conversation
Parity with Cluster API 0.3.8 Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
/test pull-cluster-api-test |
/assign @sedefsavas |
/lgtm |
/approve @sedefsavas, should kubernetes-sigs/cluster-api-provider-aws#1816 switch CAPA to use CRS (so this field won't be used anymore)? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-cluster-api-test |
@fabriziopandini Yes after that PR is in, it will be the case for CAPA but this PR is fine too to revert an undocumented breaking change, in the next release we can document and do this change.
|
/milestone v0.3.10 |
Parity with Cluster API 0.3.8
Signed-off-by: Naadir Jeewa jeewan@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3607