🌱 Reuse the same RESTMapper for cache and client #3632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/test pull-cluster-api-test |
vincepri
force-pushed
the
delegating-client-tracker-cache
branch
from
2344104
to
e5580ec
Compare
k8s-ci-robot
added
size/S
vincepri
force-pushed
the
delegating-client-tracker-cache
branch
from
e5580ec
to
dae14ec
Compare
k8s-ci-robot
added
size/XS
vincepri
changed the title
vincepri
force-pushed
the
delegating-client-tracker-cache
branch
from
dae14ec
to
0ea893d
Compare
k8s-ci-robot
added
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-cluster-api-e2e |
Signed-off-by: Vince Prignano <vincepri@vmware.com>
vincepri
force-pushed
the
delegating-client-tracker-cache
branch
from
0ea893d
to
211334d
Compare
k8s-ci-robot
added
size/XS
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano vincepri@vmware.com
What this PR does / why we need it:
This PR switches the RESTMapper used in remote cluster caches to use a more efficient delegating cached one. By default
NewDynamicRESTMappercalls https://github.com/kubernetes-sigs/controller-runtime/blob/d6829e9c4db802eb4d5703d22c6cd87e8bbf91da/pkg/client/apiutil/dynamicrestmapper.go#L109-L114which creates a new RESTMapper with the group resources discovered from the client immediately.
Given that for remote clients we don't need to know all the resources available on every client before using them, using a deferred cached client seems the most straightforward way to reduce the amount of memory pressure seen in #3609
/milestone v0.3.10
/assign @ncdc @fabriziopandini