🌱 Remove e2e templates from the code base

[fabriziopandini]

What this PR does / why we need it:
Remove e2e templates from the codebase (those files now are generated on the fly before running tests)

This is a follow up of #3651 (comment)

[fabriziopandini]

/area testing
/milestone v0.3.10

[fabriziopandini]

@vincepri apidiff is failing, but there is nothing that triggers in scripts/ci-apidiff.sh 😞

[fabriziopandini]

/test pull-cluster-api-test

[vincepri]

Is there something that's modifying the tree before running apidiff?

[sedefsavas]

/lgtm

[vincepri]

/hold

This breaks apidiff

[sedefsavas]

Adding*-template*.yamlto the .gitignore makes this fail. Not sure why.

[sedefsavas]

FYI: apidiff doesn't break when test/e2e/data/infrastructure-docker/*-template is added to the main .gitignore.

[k8s-ci-robot]

@fabriziopandini: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-cluster-api-verify-external-links	47ffedf	link	/test pull-cluster-api-verify-external-links

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[fabriziopandini]

API diff passed, thanks @sedefsavas, really appreciated!

[vincepri]

/approve
/hold cancel
/assign @sedefsavas

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sedefsavas]

/lgtm