Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Ensure correct make targets in order to build book #3709

Merged
merged 3 commits into from
Sep 29, 2020
Merged

📖 Ensure correct make targets in order to build book #3709

merged 3 commits into from
Sep 29, 2020

Conversation

randomvariable
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 29, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 29, 2020
@randomvariable
Copy link
Member Author

/hold

still don't have all the plugins working.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2020
@detiber
Copy link
Member

detiber commented Sep 29, 2020 •
edited
Loading

Added some additional details in the following slack thread: https://kubernetes.slack.com/archives/C8TSNPY4T/p1601395372085700?thread_ts=1601393918.082900&cid=C8TSNPY4T

I think the issue is the linkchecker plugin and the build image not supporting rust

@detiber detiber mentioned this pull request Sep 29, 2020
Closed
@randomvariable
book: Ensure make targets for book building
fc43e7d 
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@randomvariable randomvariable changed the title netlify.toml: Update html output directory 📖 Ensure correct make targets in order to build book Sep 29, 2020
@randomvariable
book.toml: Update bearer token
cc01260 
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 29, 2020
@randomvariable
book: disable link checker in Netlify pending access token
f598caf 
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@randomvariable
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2020
@detiber
Copy link
Member

detiber commented Sep 29, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2020
vincepri
vincepri approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/milestone v0.3.10

@k8s-ci-robot k8s-ci-robot added this to the v0.3.10 milestone Sep 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 626a8ce into kubernetes-sigs:master Sep 29, 2020
@randomvariable randomvariable deleted the update-netlify-output-dir branch September 29, 2020 17:31
@benmoss benmoss mentioned this pull request Sep 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@detiber detiber

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.10
Development

Successfully merging this pull request may close these issues.
4 participants
@randomvariable @detiber @k8s-ci-robot @vincepri