🐛 Prevents reconcileEtcdMember to remove etcd members when etcd starts slowly #3919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/milestone v0.3.11 |
k8s-ci-robot
added
the
priority/critical-urgent
|
/test pull-cluster-api-e2e-full-release-0-3 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR prevents
reconcileEtcdMemberto remove etcd members when etcd starts slowly.A slow etcd member start, which happens when then the number of etcd members in the cluster grows, determine a longer time between member Add and the actual start of the etcd pod; If during this time
reconcileEtcdMemberwas executed, the member got removed, because the member name for a member added but not yet started is empty and thus not matching any node.This PR prevents this problem by ignoring etcd members without a name in
reconcileEtcdMember; additional, as a further safeguard,reconcileEtcdMemberis now a no-op in case there are machines still provisioning (without a noderef).