Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Un-deprecate OwnedConditions and WithOwnedConditions #3936

Merged
merged 1 commit into from
Nov 20, 2020
Merged

✨ Un-deprecate OwnedConditions and WithOwnedConditions #3936

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions util/patch/options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ type HelperOptions struct {

// OwnedConditions defines condition types owned by the controller.
// In case of conflicts for the owned conditions, the patch helper will always use the value provided by the controller.
//
// DEPRECATED: Use ForceOverwriteConditions.
OwnedConditions []clusterv1.ConditionType
}

Expand All @@ -61,8 +59,6 @@ func (w WithStatusObservedGeneration) ApplyToHelper(in *HelperOptions) {

// WithOwnedConditions allows to define condition types owned by the controller.
// In case of conflicts for the owned conditions, the patch helper will always use the value provided by the controller.
//
// DEPRECATED: Use WithForceOverwriteConditions.
type WithOwnedConditions struct {
Conditions []clusterv1.ConditionType
}
Expand Down